freebsd adding getentropy interception support #3161
Conversation
devnexen
force-pushed
the
freebsd_upd2
branch
2 times, most recently
from
c7fc377 to
f32530f
Compare
| @@ -0,0 +1,11 @@ | |||
| //@only-target-freebsd | |||
There was a problem hiding this comment.
Why should this test run only on freebsd? The function seems to exist on other Unixes as well.
For macos we even have it already implemented. I guess we should add a Linux implementation. (But it's okay if you don't want to do that.)
There was a problem hiding this comment.
because I was focusing on freebsd only. we might be able to expand it in a later PR.
| let buf = this.read_pointer(buf)?; | ||
| let bufsize = this.read_target_usize(bufsize)?; | ||
|
|
||
| if bufsize > 256 { |
There was a problem hiding this comment.
Where does the magic number 256 come from? Please point to documentation.
There was a problem hiding this comment.
Interesting, even the Linux and macOS version seem to have the 256 limit (judging from my local man page and macOS man pages I found online). We forgot to check this in the macos version...
There was a problem hiding this comment.
Where does the magic number 256 come from? Please point to documentation.
sure will do.
devnexen
force-pushed
the
freebsd_upd2
branch
from
f32530f to
8fcf28f
Compare
|
@rustbot review |
|
Looks good, thanks! |
|
☀️ Test successful - checks-actions |
No description provided.